Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: smol tweaks to framegear #145

Merged
merged 3 commits into from
Feb 19, 2024
Merged

chore: smol tweaks to framegear #145

merged 3 commits into from
Feb 19, 2024
+30 −18

Conversation

cnasc
Copy link
Contributor

@cnasc cnasc commented Feb 18, 2024 •
edited
Loading

What changed? Why?

  • forgot to implement input before, now it's there
  • added Radix Icons as used in onchainkit, and replacing a literal SVG with the icon react component
    • this will be helpful when we start dealing with frame actions, as different types of buttons should have different icons associated

Notes to reviewers

How has it been tested?
image

@cnasc cnasc changed the title chore' chore: smol tweaks to framegear Feb 18, 2024
@cnasc cnasc requested a review from Zizzamia February 18, 2024 23:56
@Zizzamia Zizzamia merged commit 561906a into main Feb 19, 2024
9 checks passed
@Zizzamia Zizzamia deleted the cjn/enhancements branch February 19, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zizzamia Zizzamia Zizzamia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnasc @Zizzamia